DM-55824: Add remote-test URI scheme - #153
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
==========================================
+ Coverage 83.31% 83.46% +0.14%
==========================================
Files 36 38 +2
Lines 8025 8109 +84
Branches 972 975 +3
==========================================
+ Hits 6686 6768 +82
- Misses 1043 1044 +1
- Partials 296 297 +1 ☔ View full report in Codecov by Harness. |
3 tasks
timj
force-pushed
the
tickets/DM-55824
branch
2 times, most recently
from
August 14, 2026 19:18
5e48e68 to
0376d93
Compare
dhirving
approved these changes
Aug 14, 2026
dhirving
left a comment
dhirving
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, one nitpick on a docstring.
The key problem is that naively creating remote-test URI from an arbitrary path fails to do the correct URI escapes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a URI that is really a local file but acts like a remote file.
Also some fixes to type annotations to appease
tyand fix somepyrightwarnings.Checklist
doc/changes