DM-55824: (hotfix) Fix bad test logic - #155
Merged
Merged
Conversation
base_path is interpolated straight into a URI string, so a raw OS path leaves characters such as "+" unencoded. join() quotes only the component being joined and so preserves the unencoded base, while walk() rebuilds the URI from the OS path and encodes all of it, making the two disagree. Root the tests below a directory containing a "+" so this is always exercised. EUPS build directories embed the package version in their name, which is where this first showed up. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
_make_uri can not percent-encode the components itself: it does not know which ResourcePath class will be built from the string it returns, so it can not consult quotePaths, and encoding an already-encoded path would corrupt it. Record that requirement on the method and on base_path. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
=======================================
Coverage 83.46% 83.46%
=======================================
Files 38 38
Lines 8109 8112 +3
Branches 975 975
=======================================
+ Hits 6768 6771 +3
Misses 1044 1044
Partials 297 297 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes