DM-56138: Fix detection of byte range support for http - #158
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
==========================================
+ Coverage 83.46% 83.48% +0.01%
==========================================
Files 38 38
Lines 8112 8167 +55
Branches 975 981 +6
==========================================
+ Hits 6771 6818 +47
- Misses 1044 1048 +4
- Partials 297 301 +4 ☔ View full report in Codecov by Harness. |
A presigned S3 URL is signed for a single method, so the HEAD used to probe for range support is emulated with a one-byte ranged GET. That request is answered with 206, but only 200 was recognized, so opening such a URL fell back to reading the entire resource into memory. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The one-byte ranged GET that probes for range support reports the total size of the resource in its Content-Range header, but the handle discarded it and asked the server again the first time a seek relative to the end needed a size. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
timj
force-pushed
the
tickets/DM-56138
branch
from
September 17, 2026 22:29
49baddd to
16d6547
Compare
timj
marked this pull request as ready for review
September 17, 2026 22:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes