Revert 8 derive cleanups#9
Closed
lthiery wants to merge 5 commits into
Closed
Conversation
- edition 2021 -> 2024 in all three crates; bytescale rust-version 1.65 -> 1.85 (edition 2024 minimum) - import reordering per the 2024 style edition (rustfmt) - no code changes required; cargo fix --edition suggested expr_2021 macro fragments in test macros, kept plain expr since they only match ordinary expressions
- HumanByte derive now parses the input once and composes proc_macro2::TokenStreams directly instead of round-tripping every sub-derive through strings and re-parsing five times - unit constructors (kb, mib, ...) use checked_mul and panic on overflow instead of silently wrapping in release builds; documented and covered by a release-mode-verified regression test - fix range_stop doc (said lower bound, is upper bound) and the ByteSizeVistor -> ByteSizeVisitor typo
Stacked PRs (base = another feature branch) were getting no CI at all because of the pull_request branches filter.
This reverts commit cb7d5e0.
This reverts commit cb0bbd9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.