Skip to content

[WRONG BRANCH] fix(auth): map compact credential-substitution failures to 401 - #304

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-compact-env-key-substitution-error-handling
Draft

[WRONG BRANCH] fix(auth): map compact credential-substitution failures to 401#304
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-compact-env-key-substitution-error-handling

Conversation

@luvs01

@luvs01 luvs01 commented Aug 17, 2026

Copy link
Copy Markdown
Owner

Motivation

  • The native /v1/responses/compact path threaded bearer admission through but did not mirror the same fail-closed handling for missing stored-main credential substitution, causing an internal 500 instead of a 401 when substitution was unavailable.

Description

  • Map CodexMainSubstitutionUnavailableError to a fail-closed 401 authentication_error in the compact auth resolution path so compact requests behave the same as the main Responses path. (Change in src/server/responses/compact.ts.)
  • Add an end-to-end regression that posts to /v1/responses/compact with a bearer admission and verifies a missing stored main credential returns 401 and performs no upstream I/O. (New test in tests/codex-envkey-admission-substitution.test.ts.)
  • Small test helper added to drive the compact endpoint and integrated into the existing [Bug]: restore Codex env_key bearer admission and direct-mode OpenAI credential substitution lidge-jun/opencodex#1686 test matrix.

Testing

  • bun test tests/codex-envkey-admission-substitution.test.ts (focused): passed.
  • bun x tsc --noEmit (typecheck): passed.
  • bun run privacy:scan: passed.
  • A repository-wide bun run test / full-suite run was observed but not relied on here due to long-running unrelated tests in this environment; the focused regression and typecheck were used as the primary verification.

Codex Task

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 41 minutes

Limit details: You’ve used all 3 included reviews currently available under your plan.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 1b35715d-6a80-4d51-8ac0-e781da5a821c

📥 Commits

Reviewing files that changed from the base of the PR and between 2bd271f and ebc109f.

📒 Files selected for processing (2)
  • src/server/responses/compact.ts
  • tests/codex-envkey-admission-substitution.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 17, 2026
@github-actions

github-actions Bot commented Aug 17, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions github-actions Bot changed the title fix(auth): map compact credential-substitution failures to 401 [WRONG BRANCH] fix(auth): map compact credential-substitution failures to 401 Aug 17, 2026
@github-actions
github-actions Bot marked this pull request as draft August 17, 2026 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant