Fix HTTP header value parsing: bounds check and robust trimming#574
Merged
Fix HTTP header value parsing: bounds check and robust trimming#574
Conversation
- Add bounds check to the space-skipping loop to prevent UB when the colon is near the end of the line - Replace the unsigned arithmetic (size - start - 2) with a trim on the extracted value; avoids size_t underflow and correctly handles both \r\n and \n-only line endings - Fix isspace UB by casting to unsigned char in the lambda - Remove unused <locale> include Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
whileloop to prevent UB when the colon is near the end of the linelineStr.size() - start - 2) with a trailing trim on the extracted value — avoidssize_tunderflow and correctly handles both\r\nand\n-only line endingsisspaceUB by casting tounsigned charin the lambda<locale>includeThis is an alternative to #564 which identified the same root cause but introduced a redundant 1024-byte cap and used
intin theisspacelambda (UB for negativecharvalues).Test plan
\r(Unix line endings) parse correctly🤖 Generated with Claude Code