Conversation
API endpoints in functions/api/accounts Addresses CWE-287
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API endpoints in functions/api/accounts.js and functions/api/streams/live_inputs/index.js accept requests without any authentication validation. The code merely extracts the Authorization header from the incoming request and passes it to the Cloudflare API, but there is no validation that the request itself is authenticated. Any unauthenticated attacker can call these endpoints directly. The affected code is
functions/api/accounts.js:27. This change is the fix I would apply.Reference: CWE-287
What changed
functions/api/accounts.jsVerification
No automated check could be run against this repository, so this change is unverified beyond review. Please treat it as a suggestion.
Regression test
The security boundary is maintained under adversarial input
Test
Automated security fix by OrbisAI Security