Require streamx 2.28.1 for TypeScript declarations - #184
Open
jeffwidman wants to merge 1 commit into
Open
jeffwidman wants to merge 1 commit into
jeffwidman wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Author
|
@mafintosh 👋 this is a trivial one-line PR that fixes confusing CI failures for downstream consumer... 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
streamx2.28.1 or newerstreamxreleases that cannot satisfytar-stream's TypeScript declarationstar-stream3.2.1 imports its public stream types fromstreamx, but the existing^2.15.0range permits releases without declarations. Streamx 2.28.0 introduced declarations, and 2.28.1 added the Node core stream compatibility needed by tar-stream consumers.This currently causes TypeScript compilation failures in downstream upgrades such as github/dependabot-action#1765 unless consumers manually refresh the transitive
streamxlock entry.Closes #183.
Testing
npm test(33/33 passing)npm pack --dry-run