Update testProject nuget packages and targetframework#122
Conversation
|
@eoehen thank you for taking the time to raise this PR. Was there a specific reason that you were looking to have these changes included? We are currently working on the 2.1.0 release of Magic Chunks, so this change likely won't be included in that release, but we may consider it after that release is completed. |
pascalberger
left a comment
pascalberger
left a comment
There was a problem hiding this comment.
@eoehen Thanks for your contribution. There's one thing which additionally needs to be updated manually.
eoehen
force-pushed
the
feature/Update-TestProject-Nugets
branch
from
9a0ebd7 to
70d3f13
Compare
|
@gep13 Sorry for the misunderstanding. I ask @pascalberger first, if I can create a PR for updating this packages. You can use it for a later version. |
eoehen
force-pushed
the
feature/Update-TestProject-Nugets
branch
from
70d3f13 to
f4db813
Compare
pascalberger
left a comment
pascalberger
left a comment
There was a problem hiding this comment.
Build is currently failing: https://ci.appveyor.com/project/sergeyzwezdin/magic-chunks/builds/37326190
|
@pascalberger Build is fixed. |
3 participants
Update nuget packages of the testproject:
TargetFramework from netcoreapp2.0 to netcoreapp 2.2
DotNetCliToolReference dotnet-xunit removed