Conversation
wraps it in a table that makes it look better in old outlooks
adds touch events to drag handlers
normalize and align properly
simplify and catch more cases
change how data is presented
add background-position prop, improve dx
increase coverage
wrap in article div with font size
|
Important Review skippedToo many files! This PR contains 293 files, which is 143 over the limit of 150. To get a review, narrow the scope: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (7)
📒 Files selected for processing (293)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Column's auto-derived width now subtracts the column's own horizontal border + padding from the emitted min-width — without this, two bordered or padded cols summed past the container and wrapped under content-box sizing. data-maizzle-cw and the MSO td slot still hold the outer slice so nested rows and Outlook cells render correctly. When the column has padding but no border, Word drops div padding outright, so the padding decls are hoisted to the MSO td and the td width is shrunk by 2*horizontal-padding to keep the cell at the outer slot. background-color is always mirrored to the td so Word paints the cell behind any padded area or whitespace, not just the div. shorthandCss now also merges longhand inside MSO conditional comments so the hoisted td styles end up as clean shorthand (e.g. padding: 8px 8px 8px 16px) instead of staying as longhand-only. Column's font-size reset switched from text-base (which planted a 24px line-height that propagated into Outlook) to text-[medium] — Word-safe absolute-size keyword, no line-height, no CSS-var dependency.
Section now uses the same data-maizzle-mso-td-id plumbing as Container so that class-derived padding and background-color reach the Outlook td after CSS inlining. Before this, only the user's inline style attribute got mirrored, so `<Section class="p-6 bg-white">` was a no-op in Word. msoPlaceholders now also mirrors background-color (always, when present) and skips padding hoist when the element has a horizontal border, since Word renders div padding fine with a border and a td copy would double- pad. Affects Container too, which is a strict improvement: bg-color now paints the Outlook cell, and the rare border + padding combo no longer doubles. CSS box-model parsers moved from columnWidth into a shared src/utils/cssBox.ts so msoPlaceholders can reuse horizontalBorderPx without duplication.
normalize with Preheader component
Adds `aspect`, `position`, `size`, and `outlookFallback` props to the Img component. When `aspect` is set (or a Tailwind `aspect-*` class is detected), Img renders a padding-bottom + background-image wrapper with role="img" plus a VML `<v:rect>` for Outlook. `size` maps to VML `aspect` (cover → atleast, contain → atmost).
The post-process pass added a space after every `:` and `;`, which broke
URLs in inline style values (`url('https://...')` → `url('https: //...')`)
and forced visual consistency with Juice's spaced output that email
clients don't care about. Dropped the colon/semicolon rewriting and the
trailing-semicolon ensure; kept `preferUnitlessValues` (0px → 0) and
gated its walk on the option being enabled.
The Shiki theme background only landed on the `<pre>`, leaving the td's mso-padding-alt-4 area to show through as white in Outlook — visible as a white frame around dark themes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.