fix(agents): log warn when child.kill() fails in codex_adapter#642
Merged
majiayu000 merged 1 commit intomainfrom Apr 10, 2026
Merged
fix(agents): log warn when child.kill() fails in codex_adapter#642majiayu000 merged 1 commit intomainfrom
majiayu000 merged 1 commit intomainfrom
Conversation
Replace silent `let _ = child.kill().await` with a warn-level log so orphaned processes are visible in traces instead of silently failing. Fixes #627 Signed-off-by: majiayu000 <1835304752@qq.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request improves error handling in the CodexAdapter by explicitly checking and logging failures when attempting to kill a child process during an interrupt. Previously, the result of the kill operation was ignored; it now records the process ID and the error message. I have no feedback to provide as no review comments were submitted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
let _ = child.kill().awaitwithif let Err(e)pattern that emits atracing::warn!with the PID and errorFixes #627
Test plan
cargo fmt --all— no changescargo clippy --workspace --all-targets -- -D warnings— cleancargo test --workspace— all pass