Clarify current Karabiner migration boundaries - #1292
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Docs-only change, mostly good (dropping the unverifiable "~95%"/"19 packs"/"16 collections" figures reduces staleness risk). One thing worth double-checking before merge: migration/karabiner-users.md, "Config import" section — this PR adds a new, more specific claim that wasn't previously stated anywhere in the doc:
This introduces Goku by name for the first time in the guide with no prior context on what it is, and asserts a specific in/out-of-scope boundary for the importer (Karabiner JSON + complex-modifications rule file = supported, Goku EDN = not supported). Since this is a factual claim about importer behavior rather than a wording/terminology cleanup like the rest of the diff, please confirm it's accurate against the actual No other actionable issues found in the diff. |
|
Confirmed against the current implementation. The normal path is Goku EDN is therefore outside this importer path: the accepted inputs are JSON, and there is no EDN parser or Goku conversion branch in the command/facade/converter path. Skipped rules are carried into the CLI result at |
e3dae5c to
f83dc4c
Compare
|
Doc-only PR, changes read well overall. One thing worth double-checking before merge:
No other correctness issues spotted; the terminology changes (Full support/Partial/Not yet → Supported/Limited/Deferred, dropping the hard-coded pack counts of 19 vs 16 which were inconsistent) look like a net improvement. |
|
Rechecked after rebase at f83dc4c: the earlier implementation evidence still applies. ImportKarabinerCommand.swift lines 110–115 iterates result.skippedRules and prints each description and reason, so this is per-rule reporting, not only a count. The accepted JSON/full-profile and complex-modifications fallback paths, and absence of an EDN parser on that path, are detailed in the preceding source confirmation. Both behavioral claims are verified. |
What changed
Clarifies the current Karabiner migration boundary without promising future parity. The migration guide now distinguishes supported, limited, and deferred Karabiner capabilities, removes the temporary-loss and unsupported 95% conversion language, and documents importer-specific limits plus skipped-rule review and original-config backup guidance. The installation guide links to the boundary section.
Validation
git diff --checkPATH=/usr/bin:/bin ./Scripts/review-gate.sh→ remote review gate selected (exit 2)No Swift build, tests, publishing, or merge performed.