Add VM lab tenancy descriptor - #1297
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Per AGENTS.md, `.vm-lab.tsv` is supposed to declare to the shared VM lab: (1) the artifact the installer must contain, (2) the command that admits a lane, and (3) the managed-policy generator and verifier. This diff only adds `tenant` and `artifact_expect` — the admission command and managed-policy generator/verifier keys are missing. If the lab's admission tooling reads this file to know how to call `vm-lab keypath create`, an incomplete manifest will likely cause admission to fail or silently fall back to defaults. Please confirm whether the remaining keys are optional/added in a follow-up, or whether they're required for the lab to admit a KeyPath lane at all. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b6f1945837
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,2 @@ | |||
| tenant keypath | |||
| artifact_expect KeyPath.app | |||
There was a problem hiding this comment.
With only tenant and artifact_expect present, this descriptor does not expose Scripts/lab/mdm/verify-lane, generate-keypath-profiles, or verify-artifact-policy to the external lab. Consequently, vm-lab keypath create --lane unmanaged-ui cannot perform the required lane admission, while managed-functional creation cannot generate and validate policy for the supplied artifact; add the corresponding command entries before enabling this tenant.
AGENTS.md reference: AGENTS.md:L108-L111
Useful? React with 👍 / 👎.
1 participant
Summary\n- add the minimal tracked vm-lab descriptor for KeyPath\n- declare the KeyPath app artifact expected by the unmanaged UI acceptance lane\n\n## Validation\n- Astra review approved the TSV contract\n- \n- review-gate: running claude review prompt against origin/master...HEAD
Unknown command: /thermo-nuclear-swift-review selected the remote review path because the local reviewer command is unavailable\n\nThis is acceptance-lab metadata only; it does not alter app code.