Skip to content

Repair managed VM tenant descriptor - #1298

Merged
malpern merged 1 commit into
masterfrom
codex/repair-managed-vm-descriptor
Sep 15, 2026
Merged

malpern merged 1 commit into
masterfrom
codex/repair-managed-vm-descriptor

Conversation

@malpern

@malpern malpern commented Sep 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • declare the KeyPath managed-policy generator, lane admission, artifact verifier, and in-guest manifest path
  • restore managed-functional lease creation after the VM-lab tenancy migration

Validation

  • Astra review
  • generated policy from the signed KeyPath candidate
  • git diff --check
  • Scripts/review-gate.sh

The live managed VM acceptance run follows on this PR.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-14T23:59:09.221256Z 39ebe73 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@claude

claude Bot commented Sep 14, 2026

Copy link
Copy Markdown

Reviewed the .vm-lab.tsv diff. The added policy_generator/admission/policy_verifier keys line up with the contract AGENTS.md describes (artifact, admission command, and managed-policy generator/verifier declared per-tenant), so the shape looks right.

One thing worth double-checking before merge:

  • policy_manifest (/Library/KeyPathLab/managed-policy/manifest.json) isn't one of the fields AGENTS.md's VM Lab section calls out ("the artifact ... the command that admits a lane, and the managed-policy generator and verifier"). If this is a new contract field, please confirm the lab side actually consumes policy_manifest from this file (vs. it being unused/aspirational), and update docs/testing/remote-installer-lab.md (and/or AGENTS.md) to document it — per repo policy, docs should move with any change to the declared contract.
  • Can't verify from the diff alone that Scripts/lab/mdm/generate-keypath-profiles and Scripts/lab/mdm/verify-artifact-policy exist and are executable; worth a sanity check (vm-lab keypath list/dry run) since a typo'd path here would silently break admission rather than fail loudly.

No other correctness/security issues found in this small, purely declarative change.

@malpern
malpern merged commit 5fce69b into master Sep 15, 2026
3 checks passed
@malpern
malpern deleted the codex/repair-managed-vm-descriptor branch September 15, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant