This repository was archived by the owner on Jan 11, 2021. It is now read-only.
Added possibility to use custom schema generator#699
Open
mlubimow wants to merge 1 commit intomarcgibbons:masterfrom
Open
Added possibility to use custom schema generator#699mlubimow wants to merge 1 commit intomarcgibbons:masterfrom
mlubimow wants to merge 1 commit intomarcgibbons:masterfrom
Conversation
sasha0
suggested changes
Nov 12, 2018
| if schema_generator_cls is None: | ||
| generator_cls = SchemaGenerator | ||
| else: | ||
| generator_cls = schema_generator_cls |
There was a problem hiding this comment.
Why not to make SchemaGenerator default parameter value instead of this condition?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be handy if it would be possible to use custom schema generator without need to define a view seperately