Skip to content

Some feedback for Java 28 diffs #331

Description

@liach
  1. I hope reflective preview APIs are marked from the regular ones: reflective ones can be used by non-preview programs to support running in a preview enabled runtime. (IdentityException is not reflective, all other preview APIs added by value objects are reflective)
  2. There are preview class files in the JDK 28 distributions: See https://github.com/openjdk/jdk/blob/master/doc/value-class-preview.md, they are in META-INF/preview. You can maybe create a separate diff page or notation to indicate the difference between the META-INF/preview classes and the normal classes.

According to #141 your tool uses ASM, so I anticipate these tweaks to be relatively easy to your tool.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions