Preserve authoritative IED identity in live SCL export#34
Merged
Conversation
masarray
marked this pull request as ready for review
July 20, 2026 07:33
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
MMS discovery exposes communication-level Logical Device domain names, not a guaranteed enclosing SCL IED name. A relay can identify itself as
OCR7SJ8Mod2while exposing domains such asOCR7SJ8ApplicationandOCR7SJ8CB1. Treating the first domain as IED identity generates broken CID references and can prevent a SAS client from associating correctly.Fix
LiveIedSclExportOptions.IedNameOverride;AuthoritativeLiveIedSclExporter, which uses the proven live exporter and then normalizes identity on a cloned/generated document;<IED name>,ConnectedAP@iedName, and Header identity from the authoritative physical IED name;LDevice@ldNamewhenever the domain is not the implicitIEDName + LDevice.instform;IEDName + ldInst;Regression coverage
The tests reproduce the reported relay pattern:
OCR7SJ8Mod2;OCR7SJ8Application;OCR7SJ8Application,OCR7SJ8CB1;OCR7SJ8Mod2OCR7SJ8Application.Validation
.NET CIpassed on the final head.