Fix live IED identity and relay fault-record package download#35
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two field interoperability defects reported against a SIPROTEC endpoint:
OCR7SJ8Mod2_MU1cannot incorrectly rename the IED toOCR7SJ8Mod2when sibling domains establishOCR7SJ8FRA00019Regression coverage
OCR7SJ8Application,OCR7SJ8CB1,OCR7SJ8Dc1,OCR7SJ8Mod2_MU1,OCR7SJ8V3p1_5051OC3phase1=> IEDNameOCR7SJ8FRA00019with a non-zero size is a downloadable file/package, not a directoryTEST FILE.txtare not surfaced as fault recordsProtocol notes
The transfer still uses MMS FileDirectory, FileOpen, FileRead and FileClose with bounded traversal, byte limits, operation limits, cancellation and cleanup. COMTRADE completeness remains descriptive metadata; a single relay-provided package is classified as complete and downloadable.