Skip to content

Keep reusable MMS sessions alive after connect-operation cancellation#37

Merged
masarray merged 2 commits into
mainfrom
fix/mms-session-receive-pump-lifetime
Jul 20, 2026
Merged

Keep reusable MMS sessions alive after connect-operation cancellation#37
masarray merged 2 commits into
mainfrom
fix/mms-session-receive-pump-lifetime

Conversation

@masarray

Copy link
Copy Markdown
Owner

Field failure reproduced from ARSAS

The fault-record scan succeeded, but starting Download cancelled the previous UI operation token. MmsClientSession had started its receive pump with that connection token, so the pump stopped while the session still reported MmsInitiated. The next FileOpen/FileRead then failed through stale confirmed-service routing, matching the observed first-chance sequence OperationCanceledExceptionInvalidOperationExceptionInvalidDataException.

Changes

  • add an explicit API to rebind the receive pump from a short-lived connect/scan token to the MMS association lifetime
  • refuse rebinding while confirmed operations are pending
  • verify transport, association state and pump state after rebinding
  • add a regression test proving that cancelling the completed connect-operation token no longer stops later confirmed responses

This does not change file filtering or COMTRADE interpretation. The transfer engine remains generic MMS FileOpen/FileRead/FileClose; COMTRADE grouping stays above the transport layer.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@masarray
masarray merged commit c116fce into main Jul 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant