Keep reusable MMS sessions alive after connect-operation cancellation#37
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Field failure reproduced from ARSAS
The fault-record scan succeeded, but starting Download cancelled the previous UI operation token.
MmsClientSessionhad started its receive pump with that connection token, so the pump stopped while the session still reportedMmsInitiated. The next FileOpen/FileRead then failed through stale confirmed-service routing, matching the observed first-chance sequenceOperationCanceledException→InvalidOperationException→InvalidDataException.Changes
This does not change file filtering or COMTRADE interpretation. The transfer engine remains generic MMS FileOpen/FileRead/FileClose; COMTRADE grouping stays above the transport layer.