Support signed MMS FRSM IDs during file transfer#38
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Field evidence
Directory discovery is now correct, but
Download selectedstill fails on a BCU endpoint after FileOpen/FileRead begins. The only surfaced first-chance exception isInvalidDataException.Root cause addressed
ISO 9506 defines the FileOpen response
frsmIDasInteger32, not an unsigned value. The existing decoder rejected negative values and the FileRead/FileClose request builders also threw for any FRSM below zero. Several MMS servers allocate negative FRSM handles, so a valid FileOpen response was being converted into a failed transfer.Changes
-1sentinel with a nullable FRSM in the interoperable transfer pathRegression coverage
-17succeeds-1,-17,int.MinValue, and positive IDs correctlyThe existing public transfer path is left intact; ARSAS opts into the compatibility path for field interoperability.