fix: Fixes #12. Update tx list page to show transactions to all contracts and self-transactions#19
Open
ltfschoen wants to merge 1 commit into
Open
Conversation
… all contracts and self-transactions * [x] Add some docs and refactor to `getTransaction` * [x] Add `isRecipientContract` to detect ERC20 token transfers (i.e. using https://erc20faucet.com/), since the `isContractInteraction` function does not appear to detect them * [x] Add support for detecting when transaction was sent to the original sender by using `tweakTxs` to add type `self-interaction` * [x] Call `tweakTxs` for both `refreshTransactions` and `fetchTransactions` so that UI always shows the correct values * [x] Removed the `direction` function as it didn't appear to be necessary (unnecessary complexity) Note: Extends upon changes in PR matchx-dev@764576a Note: Incorporates approaches that were adopted in PR https://github.com/mxc-foundation/mxc-wallet/pull/18/files, which was incorrectly using the 'master' branch instead of the 'develop' branch, so it didn't have any of the changes that had already been made in PR matchx-dev@764576a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getTransactionisRecipientContractto detect ERC20 token transfers (i.e. using https://erc20faucet.com/), since theisContractInteractionfunction does not appear to detect themtweakTxsto add typeself-interactiontweakTxsfor bothrefreshTransactionsandfetchTransactionsso that UI always shows the correct valuesdirectionfunction as it didn't appear to be necessary (unnecessary complexity)Note: Extends upon changes in PR 764576a
Note: Incorporates approaches that were adopted in PR https://github.com/mxc-foundation/mxc-wallet/pull/18/files, which was incorrectly using the 'master' branch instead of the 'develop' branch, so it didn't have any of
the changes that had already been made in PR 764576a
Screenshot: