Fix broken CI actions and incompatible Monty pin - #367
Closed
Demfier wants to merge 1 commit into
Closed
Conversation
Author
|
Folded these CI repairs directly into benchmark submission PR #366 as requested, so this duplicate repair PR is no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current CI fails before benchmark submissions can be validated for two independent upstream reasons:
actions/upload-artifact@v2is retired, so the Python 3.9 test job stops at artifact upload.requirements-dev.txtdowngrades Monty to2022.4.26after current matminer/pymatgen have been installed. Those packages require newer Monty, and the benchmark-submission job then fails during import withTypeError: deprecated() got an unexpected keyword argument deadline.\n\nThis PR upgrades the official GitHub actions to their current Node-compatible releases and changes the Monty development constraint to the minimum required by the currently resolved pymatgen (>=2024.7.29). It does not change MatBench scoring or submission validation logic.