Skip to content

Add audino-libraries equivalent CI#35

Closed
peternewman wants to merge 7 commits into
mathertel:masterfrom
peternewman:patch-6
Closed

Add audino-libraries equivalent CI#35
peternewman wants to merge 7 commits into
mathertel:masterfrom
peternewman:patch-6

Conversation

@peternewman

Copy link
Copy Markdown
Contributor

No description provided.

@peternewman peternewman mentioned this pull request Jun 8, 2021
@peternewman

Copy link
Copy Markdown
Contributor Author

Due to GitHub config you'll need to look at the top run for each of the action types on the left of:
https://github.com/peternewman/DmxSerial2/actions

@peternewman

Copy link
Copy Markdown
Contributor Author

@mathertel do you want this closed then given 36586c3 ?

I would suggest switching to a matrix makes the config simpler to read and tweak.

@mathertel

Copy link
Copy Markdown
Owner

Hi @peternewman
Thanks for pointing me into this direction - it's really good value !
almost time to close it. :-)
your files contain some useful things I like to take into the current configurations.

@peternewman

Copy link
Copy Markdown
Contributor Author

Thanks for pointing me into this direction - it's really good value !

No worries, I've always been a fan of CI.

almost time to close it. :-)

Feel free when you're happy the equivalent functionality is in place.

Comment thread .github/workflows/check-arduino.yml
@mathertel

Copy link
Copy Markdown
Owner

Please add top the existing github actions

@mathertel mathertel closed this Jan 21, 2022
peternewman added a commit to peternewman/DmxSerial2 that referenced this pull request Jan 26, 2022
@peternewman

peternewman commented Jan 26, 2022

Copy link
Copy Markdown
Contributor Author

Please add top the existing github actions

They didn't exist when I first created this...

I'd suggest in general just leaving a review with changes would make it easier to manage than closing the PR outright. Anyway I've opened #41 with some progress (and so I don't forget about this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants