Skip to content

Drop array custom-variable name from tracking fixture for matomo-php-tracker 4.0 #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sgiehl merged 2 commits into from
Jul 28, 2026
Merged

Drop array custom-variable name from tracking fixture for matomo-php-tracker 4.0 #137

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edbc59c
Drop the array custom-variable name from the tracking fixture
sgiehl Jul 24, 2026
21f3011
Recover the malformed-custom-variable coverage via direct cvar injection
sgiehl Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests/Fixtures/TwoVisitsWithCustomVariables.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,10 @@ private function trackVisits()
$visitorB->setCustomVariable($id = 2, $name = 'Othercustom value which should be truncated abcdefghijklmnopqrstuvwxyz', $value = 'abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz');
$visitorB->setCustomVariable($id = -2, $name = 'not tracked', $value = 'not tracked');
$visitorB->setCustomVariable($id = 6, $name = 'not tracked', $value = 'not tracked');
$visitorB->setCustomVariable($id = 6, $name = array('not tracked'), $value = 'not tracked');
// A custom variable with a non-string (array) name can no longer go through the
// type-safe setCustomVariable(); inject it straight into the cvar payload so we
// still verify a malformed custom variable is not tracked.
$visitorB->visitorCustomVar[6] = array(array('not tracked'), 'not tracked');
$visitorB->setUrl('http://example.org/homepage');
self::checkResponse($visitorB->doTrackGoal($idGoal, 1000));

Expand Down
Loading