MM-68992 - add attribute value masking documentation#9000
Conversation
|
Newest code from mattermost has been published to preview environment for Git SHA 3541fde |
amyblais
added
1: Dev Review
davidkrauser
left a comment
davidkrauser
left a comment
There was a problem hiding this comment.
Looks great - thanks for documenting this. Have a few comments, but pre-approving.
|
|
||
| .. note:: | ||
|
|
||
| If a policy rule references attribute values you don't hold, those values appear as ``--------`` and the row is read-only. Test and Delete actions are also disabled for those rows. See :ref:`Attribute value masking <administration-guide/manage/admin/abac-system-wide-policies:attribute value masking>` for details. |
There was a problem hiding this comment.
This is only for shared_only attributes, right? Should we specify that?
There was a problem hiding this comment.
agree, better to clarify this.
| Attribute access modes | ||
| ----------------------- | ||
|
|
||
| Each user attribute has an **access mode** that controls who can see its values when those values appear in access control policies. The access mode is set per attribute and determines whether an admin editing a policy can see the raw attribute values referenced in its rules. |
There was a problem hiding this comment.
Should we specify that these access modes are only available for custom plugins to set?
There was a problem hiding this comment.
yes, that makes sense. Is hard even for us internally to get how this exactly works. Will add a new section briefly explaining this. I will ask you again for feedback once done @davidkrauser 👍
|
Newest code from mattermost has been published to preview environment for Git SHA 9f98329 |
|
@davidkrauser one quick look to commit 9f98329 🙏 |
|
@amyblais @marianunez since we are not enabling the FF for this 11.8 release, perhaps we want to hold on this PR so it wont cause confusion on customers. |
@pvev Sounds good, I'll rebase it to master. |
amyblais
added
Do Not Merge/Awaiting Next Release
3 participants
Summary
Adds attribute value masking documentation
Ticket Link
https://mattermost.atlassian.net/browse/MM-68992