ci: drop redundant Dgraph standalone from -short unit job#21
Open
mlwelles wants to merge 3 commits into
Open
Conversation
The unit-test job runs `go test -short`, which skips every test that needs a live Dgraph. Standing up a dgraph/standalone container (and setting MODUSGRAPH_TEST_ADDR) therefore adds setup the job never uses. Remove both; the integration and load suites keep their own dedicated jobs.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
The Trunk config pinned trivy@0.59.1, but that release does not exist on github.com/aquasecurity/trivy — Trunk's templated download (.../v0.59.1/trivy_0.59.1_Linux-64bit.tar.gz) returns HTTP 404, failing the Trunk Code Quality check on any PR whose diff trivy scans (e.g. workflow or broad changes) while reporting no actual lint issues. Bump to trivy@0.69.3, a real release with the expected Linux-64bit asset. The plugin (v1.6.7) downloads trivy via a version-templated URL, so no other change is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The unit-test CI job runs
go test -short, which skips every test that needs alive Dgraph. That job also stood up a
dgraph/standalonecontainer and setMODUSGRAPH_TEST_ADDR— setup the-shortjob never uses.This removes the Set up Dgraph step and the
MODUSGRAPH_TEST_ADDRenv from theunit-test job. Integration and load suites keep their own dedicated jobs and are
unaffected.
Why
Standing up a database the job never touches adds minutes and a flaky external
dependency to every unit run for no coverage. Removing it makes the unit job
faster and more reliable.
No test coverage changes —
go test -short -race -v .still runs on both Linuxand macOS. The automated review (cubic) found no issues.