Skip to content

feat: Keep Android sample repo folder present after clone#304

Merged
avner-m merged 1 commit into
masterfrom
fix/android-repo-folder-gitkeep
Jun 23, 2026
Merged

feat: Keep Android sample repo folder present after clone#304
avner-m merged 1 commit into
masterfrom
fix/android-repo-folder-gitkeep

Conversation

@avner-m

@avner-m avner-m commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Problem

A customer following the Android SDK quickstart reported that the downloaded sample app has no repo folder, so they couldn't complete the step:

Drag the unzipped global folder into the project's repo folder.

Root cause

All three Android tutorial sample apps reference a local Maven repo folder from settings.gradle.kts:

maven { url = uri("repo") }

The folder was empty, and git does not track empty directories — so it is absent on a fresh clone or download-directory.github.io download. The quickstart step then has no target folder. (*/repo/global/ is gitignored, which is correct — the SDK contents should not be committed.)

Fix

Add a repo/README.md to each of the three Android samples:

  • android-holder-tutorial-sample-app
  • android-in-person-verifier-tutorial-sample-app
  • android-remote-verification-tutorial-sample-app

The README keeps the otherwise-empty folder present after clone/download, and documents what goes there (repo/global/), referencing the correct SDK artifact per sample (holder vs verifier). SDK contents stay gitignored.

Testing

  • Confirmed repo/ is now tracked by git in all three samples.
  • Confirmed repo/.gitkeep/README.md is not caught by .gitignore (only */repo/global/ is ignored).
  • Verified artifact wording against each app/build.gradle.kts (global.mattr.mobilecredential:holder vs :verifier).

🤖 Generated with Claude Code

The three Android tutorial sample apps reference a local Maven `repo`
folder from settings.gradle.kts (`maven { url = uri("repo") }`), but the
folder was empty and therefore not tracked by git. On a fresh clone or
download the folder is missing, so the quickstart step "Drag the unzipped
global folder into the project's repo folder" has no target.

Add a README.md to each sample's repo folder documenting what goes there
and why repo/global/ is gitignored. This keeps the folder present while
leaving the SDK contents excluded from version control.
@avner-m avner-m requested a review from a team as a code owner June 23, 2026 02:33
@avner-m avner-m changed the title Keep Android sample repo folder present after clone feat: Keep Android sample repo folder present after clone Jun 23, 2026
@avner-m avner-m merged commit 70f9bfb into master Jun 23, 2026
2 checks passed
@avner-m avner-m deleted the fix/android-repo-folder-gitkeep branch June 23, 2026 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants