[DESK-23336] bridgev2: add min/max length hints to login input fields - #564
Merged
Conversation
Clients only receive a regex pattern for user input fields, so to know how many characters to accept they would have to parse the regex. Bridges that ask for fixed-length codes can now say so directly, letting clients cap the input and render a proper code field.
SilverBirchh
changed the title
tulir
reviewed
Sep 4, 2026
Comment on lines
+318
to
+319
| MinLength int `json:"min_length,omitempty"` | ||
| MaxLength int `json:"max_length,omitempty"` |
Member
There was a problem hiding this comment.
omitempty only omits null and empty objects/arrays in jsonv2, so to prepare for that, ints and booleans need to use omitzero instead (which omits zero values defined by go, like 0, false, nil and probably empty non-pointer structs too)
They should also be added to the openapi doc (./matrix/provisioning.yaml)
Suggested change
| MinLength int `json:"min_length,omitempty"` | |
| MaxLength int `json:"max_length,omitempty"` | |
| MinLength int `json:"min_length,omitzero"` | |
| MaxLength int `json:"max_length,omitzero"` |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clients only receive a regex pattern for user input fields, to know how many characters to accept they would have to parse the regex. Bridges that ask for fixed-length codes can now say so directly, letting clients cap the input and render a proper code field.
Checklist