messagix/bloks: allow choosing a different mfa type - #340
Merged
Conversation
tulir
approved these changes
Aug 31, 2026
| case <-timer.C: | ||
| case <-ctx.Done(): | ||
| if !timer.Stop() { | ||
| <-timer.C |
Member
There was a problem hiding this comment.
This is no longer needed as of Go 1.23 https://go.dev/wiki/Go123Timer, just use a plain time.After in the select
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the interface defined in mautrix/go#560 to allow canceling the MFA step after selecting an MFA method, and having that return the user to the MFA selection screen to choose a different method. The option to go back is only presented if there is at least one other supported MFA method to select.
On clients that don't support mautrix/go#560, there is no change in behavior.