msgconv: fixed images getting removed after editing the message - #129
Open
highesttt wants to merge 1 commit into
Open
msgconv: fixed images getting removed after editing the message#129highesttt wants to merge 1 commit into
highesttt wants to merge 1 commit into
Conversation
tulir
reviewed
Aug 31, 2026
|
|
||
| type StoredMediaContent struct { | ||
| Content *event.MessageEventContent `json:"content"` | ||
| Extra map[string]any `json:"extra,omitempty"` |
Member
There was a problem hiding this comment.
Storing message content is not allowed
Contributor
Author
There was a problem hiding this comment.
Yeah I was worried that'd be the case... I think it might be harder to fix without that 😬
Member
There was a problem hiding this comment.
Temporary in-memory caching is allowed and might be enough if there's an edit time limit. I think WhatsApp does that. Otherwise might need something like fetching the message from twitter
Contributor
Author
There was a problem hiding this comment.
There isn't an edit time limit, but I do have something else I'd like to try locally first, might be worth trying
highesttt
marked this pull request as draft
August 31, 2026 18:44
highesttt
force-pushed
the
highest/plat-38684
branch
from
September 1, 2026 02:26
236bbf2 to
bd50581
Compare
highesttt
force-pushed
the
highest/plat-38684
branch
from
September 1, 2026 02:27
bd50581 to
823cf79
Compare
highesttt
marked this pull request as ready for review
September 1, 2026 02:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist