Set length hints on the juicebox PIN login field - #130
Closed
SilverBirchh wants to merge 1 commit into
Closed
Conversation
Lets clients cap the PIN input at 4 digits instead of silently disabling submit when a 5th digit is typed. Needs the mautrix-go change that adds MinLength/MaxLength to LoginInputDataField.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
MinLength/MaxLengthto 4 on the juicebox PIN field so clients can cap the input instead of silently disabling submit when a fifth digit is typed (beeper DESK-23336).Depends on the mautrix-go change adding those fields to
LoginInputDataField: https://github.com/SilverBirchh/go/tree/login-field-length. Needs a go.mod bump once that merges.