Skip to content

Remove FastClick #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
byronigoe wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Remove FastClick #428

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1c6d3c3
Removed FastClick, which should not be needed with modern browsers an…
byronigoe Apr 23, 2018
687d9e0
New build assets
byronigoe Apr 23, 2018
ed5e96c
New NPM version uses package-lock
byronigoe Apr 23, 2018
ae8337a
Remove 3d transforms to not use the GPU
byronigoe Apr 25, 2018
3f765ba
New build assets
byronigoe Apr 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/less/lib/app.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
width: 100%;
background: @app-bg;
overflow: hidden;
.translate3d(0,0,0);
Copy link
Copy Markdown
Owner

@mcasimir mcasimir May 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why is that better?

Copy link
Copy Markdown
Author

@byronigoe byronigoe May 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translate3d is used to force use of the GPU, but a side-effect of this is that the sidebar-right won't open on a desktop screen.

Copy link
Copy Markdown
Owner

@mcasimir mcasimir May 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kinda can't reproduce it. It would be better to confirm it before. I'd say is at least a distinct bug.

.transition-transform(~"400ms ease");
.box-shadow(@app-shadow);
}
Expand All @@ -31,4 +30,4 @@
border-width: 0 0 1px;
z-index: @zindex-app-search;
width: 100%;
}
}
3 changes: 1 addition & 2 deletions src/less/lib/sidebar.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
top: 0;
bottom: 0;
display: none;
.translate3d(0, 0, 0);
.transition-transform(~"400ms ease");
pointer-events: none;
}
Expand Down Expand Up @@ -54,4 +53,4 @@
color: @sidebar-header-color;
margin: 0;
z-index: @zindex-sidebar-header;
}
}
19 changes: 3 additions & 16 deletions src/less/mobile-angular-ui-desktop.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,22 +13,22 @@
@import "bootstrap/less/jumbotron.less";

@media (min-width: @screen-desktop) {

.sidebar {
pointer-events: auto;
}

.sidebar-toggle {
display: none;
}

.navbar-brand-center {
text-align: left;
width: auto;
float: left;
position: relative;
}

.sidebar-left {
display: block;
left: 0;
Expand All @@ -43,24 +43,15 @@
}

.sidebar-right-in .sidebar-left {
-webkit-transform: translate3d(0, 0, 0) !important;
-moz-transform: translate3d(0, 0, 0) !important;
transform: translate3d(0, 0, 0) !important;
}

.sidebar-left-in .sidebar-right {
-webkit-transform: translate3d(0, 0, 0) !important;
-moz-transform: translate3d(0, 0, 0) !important;
transform: translate3d(0, 0, 0) !important;
}

.has-sidebar-left .app, .sidebar-left-in .app {
width: auto;
margin-left: @sidebar-left-width-md;
left: 0;
-webkit-transform: translate3d(0, 0, 0) !important;
-moz-transform: translate3d(0, 0, 0) !important;
transform: translate3d(0, 0, 0) !important;
position: relative;
-webkit-transition: -webkit-transform 0 ease;
-moz-transition: -moz-transform 0 ease;
Expand All @@ -71,9 +62,6 @@
width: auto;
margin-right: @sidebar-right-width-md;
right: 0;
-webkit-transform: translate3d(0, 0, 0) !important;
-moz-transform: translate3d(0, 0, 0) !important;
transform: translate3d(0, 0, 0) !important;
position: relative;
-webkit-transition: -webkit-transform 0 ease;
-moz-transition: -moz-transform 0 ease;
Expand All @@ -95,4 +83,3 @@
margin-right: @sidebar-right-width-lg;
}
}

12 changes: 4 additions & 8 deletions src/less/sm-grid.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@
width: @sidebar-right-width-xs;
}
.sidebar-left-in .app {
.translate3d(@sidebar-left-width-xs, 0, 0);
.translate(@sidebar-left-width-xs, 0);
}
.sidebar-right-in .app {
.translate3d(-@sidebar-right-width-xs, 0, 0);
.translate(-@sidebar-right-width-xs, 0);
}
}

Expand All @@ -29,13 +29,9 @@
width: @sidebar-right-width-sm;
}
.sidebar-left-in .app {
.translate3d(@sidebar-left-width-sm, 0, 0);
.translate(@sidebar-left-width-sm, 0);
}
.sidebar-right-in .app {
.translate3d(-@sidebar-right-width-sm, 0, 0);
.translate(-@sidebar-right-width-sm, 0);
}
}