bump(mcpp.plugins): 0.7.0, the Slang rule takes the project's arguments, per-file ones, and a storage - #401
Merged
Merged
Conversation
…ts, per-file ones, and a storage
Three things a real Slang project needed and `mcpp.rules.slang` could not say,
found by transcribing xrgui's shader config (17 shaders, five common slangc
flags, one shader with a flag of its own, `.spv` files loaded at run time):
options::extra_args slangc takes some two hundred options; the rule keeps
the ones that decide WHAT is produced and passes the
rest through verbatim, before `-o`.
options::per_file what one shader gets that the others do not, without
leaving one `compile()` call -- a second call rewrote
the generated module with only its own shaders. A key
naming no shader is refused, listing the shaders seen.
options::storage the axis `rules-spirv` already had: header (embed, the
default), object, sidecar.
`profile_for` gains the Vulkan 1.4 row. No engine floor moves.
The archive was downloaded twice and hashed the same; the CN asset was
published from that file with gtc and read back byte-identical
(165daa19...340c, 208991 bytes). No package in this index pins `mcpp.plugins`,
so moving `latest` re-pins no consumer.
mcpp-community/mcpp-plugins#17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracks mcpp-community/mcpp-plugins#17, tag
v0.7.0.mcpp.rules.slanggainsoptions::extra_args(verbatim slangc arguments, before-o),options::per_file(per-shader defines and arguments inside onecompile()call; a key naming no shader is refused listing the shaders seen) andoptions::storage(header / object / sidecar, the axisrules-spirvalready had).profile_forgains the Vulkan 1.4 row. No engine floor moves.165daa19feaae3823f2bc52551c0c4f7e04ab218abad8b6b930635e6d214340cgtc, read back with a real GET: 200, 208991 bytes, byte-identicallatest0.6.0 → 0.7.0 on all three platforms; no package in this index pinsmcpp.pluginsConsumer this unblocks: Sunrisepeak/xrgui#8.