bump(mcpp.plugins): 0.7.1, nothing in the package instantiates std::filesystem::path's iterator - #403
Merged
Merged
Conversation
…ilesystem::path's iterator
Under MSVC 14.52 (36629 and 36725, measured on xrgui's CI) a module whose
BMI carries std::filesystem::path's iterator poisons every importer that
touches path again:
filesystem(1572): error C2801: '_Path_iterator<...>::operator ==' must be
a non-static member
the STL's own hidden friend. 0.7.1 changes no member's interface: the lib
root reads paths apart as strings and the members' relative-path arithmetic
is one string helper. 0.7.0 is unusable on that toolset for any consumer
whose host modules touch a path, which is why `latest` moves.
Archive downloaded twice and hashed the same; CN asset published from that
file with gtc and read back byte-identical. No package in this index pins
mcpp.plugins.
mcpp-community/mcpp-plugins#18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracks mcpp-community/mcpp-plugins#18, tag v0.7.1. Under MSVC 14.52 (36629 and 36725, xrgui CI) a module whose BMI carries the path iterator poisons every importer that touches path again (C2801 at filesystem(1572)); 0.7.1 removes every instantiation from the package. GLOBAL archive hashed twice:
a8d1b4dc8187c2b67a17d997245a4e4a3d52e26251f4c824fc5b951b58bbe293; CN asset published with gtc and read back byte-identical;latest0.7.0 -> 0.7.1; local lints pass. Consumer: Sunrisepeak/xrgui#8.