0.13.0 --- openkal 0.13: whether a node may be started, and a start that is not a program - #27
Merged
Merged
Conversation
…hat is not a program kal_fs_set_executable_at and the KAL_INFO_EXECUTABLE field of an enquiry. This kernel stores the property as three bits; a class that may read the node may start it, and clearing clears all three. The volume is asked through the same classification kal_fs_props already makes, and a format that stores no mode does not claim KAL_FS_PROP_EXECUTABLE. ENOEXEC maps to kal_err_not_program. The report pipe already carried the kernel's value to the caller; translate folded it into kal_err_io in its default arm, so posix_spawn above this implementation returned EIO for a file that is there and is not a program. tests/conformance_additions.cpp observes the value and was run red with the mapping removed. Comments carry no emoji.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows mcpplibs/openkal
openkal-0.13.kal_fs_set_executable_atandKAL_INFO_EXECUTABLE: three mode bits, one property; a class that may read may start, clearing clears all three.KAL_FS_PROP_EXECUTABLEis claimed for formats that store a mode, through the classificationkal_fs_propsalready makes.ENOEXECmaps tokal_err_not_program(was folded intokal_err_io).tests/conformance_additions.cppobserves both; thekal_err_not_programassertion was run red with the mapping removed.Local:
mcpp test7 passed; surface 104 names complete; conformancefull,optional190 held, 0 did not hold, 3 not observed.