Skip to content

No touch header support - #60

Closed
msoos wants to merge 5 commits into
developfrom
no-touch-header
Closed

msoos wants to merge 5 commits into
developfrom
no-touch-header

Conversation

@msoos

@msoos msoos commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Implement #59

@Gad1001 -- Check this PR out, hopefully you can figure out how to build. Usually just:

git clone https://github.com/meelgroup/arjun
cd arjun
git checkout no-touch-header
mkdir build && cd build
cmake ..
make -j4

If that doesn't work, ask an AI.

msoos and others added 5 commits August 27, 2026 00:06
Variables Arjun must keep verbatim: same numbering, never eliminated,
never dropped from the sampling set. Must be the prefix 1..k and every
one of them must also be in "c p show". The count is then preserved
conditioned on every assignment of 1..k, not just globally.

The prefix property means a single count is the whole set, and
orig_to_new_var already tracks each var through every renumbering, so
nothing new has to be maintained per-pass:

- backward: pinned into indep, never a candidate for removal
- get_empty_occs()/puura: held back (with their equivalence class)
  before clean_sampl_get_empties(), which elims the empties it finds
- get_cnf(): re-materialised when CMS fixes one, collapses two into
  one, or maps one to a NEGATED literal -- the last of these otherwise
  silently flips the var's polarity in the output
- renumber_sampling_vars_for_ganak(): placed back at slots 0..k-1

Rejected with --synth and with --renumber 0.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@msoos msoos changed the title No touch header No touch header support Aug 26, 2026
@msoos

msoos commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator Author

Ah, shit, that will not work. You need the develop cryptominisat. Oops. Ask an AI how to do it. Basically, you need to build cryptominisat's develop branch EXACTLY as above, and then you need to do the same thing as I wrote above except:

cmake -Dcryptominisat5_DIR="../../cryptominisat/build" ..

Where cryptominisat should have been cloned to ../../cryptominisat/ and built in ../../cryptominisat/build relative to arjun/build/.

So:

git clone https://github.com/msoos/cryptominisat
cd cryptominisat
git checkout develop
mkdir build && cd build
cmake ..
make -j4
cd../../

git clone https://github.com/meelgroup/arjun
cd arjun
git checkout no-touch-header
mkdir build && cd build
cmake  -Dcryptominisat5_DIR="../../cryptominisat/build" ..
make -j4

should do the trick

@msoos

msoos commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator Author

Try to follow the above. It should work. But don't struggle, just ask an AI like

https://chat.deepseek.com

Talk to it, in 3 minutes it'll guide you through how to do this. Don't struggle for hours, just ask the AI.

@msoos
msoos deleted the branch develop September 12, 2026 20:21
@msoos msoos closed this Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant