refactor(storetest): split shared suite into per-domain sub-suites#56
Merged
Conversation
Replace the 1820-line single Run function (carrying nolint:funlen,gocognit) with a thin orchestrator that calls one named sub-suite per storage domain plus a cross-cutting context-cancellation sweep. Adding a new domain now means adding a sub-suite file and one call in Run, rather than scrolling through one mega-function. Test names at the leaves are preserved so existing grep targets and CI logs keep matching. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Runfunction (with//nolint:funlen,gocognit) ininternal/storetest/storetest.gowith a thin orchestrator that calls one named sub-suite per storage domain plus a cross-cutting context-cancellation sweep.principals.go,roles.go,provisioning.go,identity.go(link/resolve/provision + concurrency),passkey.go,oidc.go,tokens.go,context.go. Shared factories move intofixtures.gowith one-line godocs.master(go doc ./internal/storetest): still exactlyfunc Run(...)andtype Store interface{ ... }.create principal/creates user principal) are preserved so existing grep targets and CI logs keep matching.//nolint:funlen(andgocognitwhere needed) with a clear rationale; the original mega-suite suppression onRunis removed.This is PR A of a three-PR storage-package refactor pass; PR B and PR C touch
store/memoryandstore/postgresrespectively and both depend on this one landing first.Test plan
go test ./...from repo root (incl.TestSharedStoreBehavioragainst memory)moon run root:check --summary minimal(vet, lint, build, unit tests)moon run root:integration(postgres Testcontainers suite)git diff --check(no whitespace damage)go doc ./internal/storetestmatchesmaster🤖 Generated with Claude Code