Update Castro - #1
Open
melilly wants to merge 261 commits into
Open
Conversation
* dataset processing can run in parallel * added code to make interactive plots of each dataset that show the raw slice data, the averaged profile, and the positions for each metric * metric thresholds are calculated using both the local maximum and global maximum at the same time (under <field>[<fac>%] and <field>[<fac>%]_gmax, respectively) * the local maximum for each field is stored in the output file, in the max_<field> column * if a field value never goes below the threshold for a metric, its position will be stored as NaN * --[xyz]lim arguments now work, despite some yt bugs * allow ignoring plotfiles after a certain time with --tmax * default FRB resolution is set to match the finest level, and is automatically adjusted if custom limits are used
…ffusion test (#3054) Updates problem_bc_fill to do either face-centered or cell centered depending on where castro.diffuse_use_amrex_mlmg is used. Gets 2nd order accuracy (with L-inf error) with max_level=0 for 2d spherica To test theta dependence, the analytic solution of spherical-bessel function and legendre polynomial is used. Currently only castro evaluation works. Also added an 2d spherical input file for noncenter Gaussian, a convergence test for this still needs to be done in the future.
if we mistakenly target "main" and then switch to "development", then check-ifdefs, codespell, and docs never run. This changes the action to look like the others so these should hopefully run.
some of the inputs were redudant also renamed a few updated the README.md finally added a dt option to the profiles.py script
we fill this in Microphysics, but it was not being captured in job_info
* 1D inputs and new model * update README * update 1d lower boundary
r is the reduction parameter but we were also using it in the reduction loop for the radius (for 2D spherical)
also disable a new check
…3061) this shows the mass fractions behind the detonation
add papers
we can't to .ptp() anymore, but instead should use np.ptp()
some loop counters were also uninitialized. this also fixes a few compiler warnings.
also remove some old inputs files
…3073) a common error is to build the executable, do a run, and then change the network by building with NETWORK_DIR set, without a "make clean". This leads to an undefined behavior. This adds a check to ensure that when we make we are using the same network as done originally, and if not, aborts with a message saying to do "make clean"
Mainly adds the convergence results, both analytic and resolution-wise, to the readme.
When using the richardsonconvergence script, I have a modified version in this branch, where I switch to use volume weighted average down from fine to coarse resolution and normalize the norm with dV_{i,j,k} directly instead of dx dy dz. But it didn't make a big difference.
Here I'm using the non-center gaussian with power law conductivity for testing. It's basically 2nd order with 1 AMR level.
we now have a parameter about whether to include recombination neutrinos
I think this is due to the fundamental constants
This now matches what was used for the runs in my most recent paper (https://arxiv.org/abs/2505.13879, https://zenodo.org/records/15468673)
it seems with Sphinx 9.x, \begin{align} ... \end{align}
no longer works in a math role. Curiously, \begin{aligned} works :/
but it does the alignment automatically if the & characters are
present
now we don't take the log if enuc = 0 also change the output filename for snapshot to use better units for small times
also remove the other inputs files, since we don't have the models here
Mainly wanna test how modulations in rotation would change things compared to fixed latitude rotation
this is new scaling on Frontier. This includes a new setup that is H/He, since that uses a more complex network.
Bumps [actions/checkout](https://github.com/actions/checkout) from 6 to 7. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v6...v7) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
this is no longer used by Microphysics
this just moves some if-logic out of the GPU kernel.
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 6 to 7. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v6...v7) --- updated-dependencies: - dependency-name: actions/setup-python dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
also sync up the order with GNUmakefile to clean the diff
we don't need fetch-depth unless we are looking at tags or older commits we don't need fortran
Rosenbrock runs this problem about 2x faster, and seems to have less issues with hard burns. also sync up the N14 and NSE 2D inputs files
…3369) this also adds a make function to color the text green so it stands out
this changes how the body is added to the release -- it now outputs it to a file and uses body_path. The old way was not working with the way that Github actions use environment variables anymore
…ction without shifting amr levels. (#3357)
This PR prints out the deviates assigned to StarLib rates in job_info within plotfiles. The preprocessor directive that flags the presence of StarLib rates is defined in a corresponding PR to pynucastro.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.