[pull] main from containerd:main#405
Merged
Merged
Conversation
Perform an early validation check on both container checkpoint and restore paths to fail-fast if the CRIU binary is missing or is older than the minimum required version (3.16.0). To support runtime-configured environments, the validation respects the custom PATH from the shim manager environment if configured, skipping any relative paths to avoid incorrect daemon-relative resolution. If not configured, it falls back to a standard system PATH lookup. The check result is cached using sync.Once to prevent redundant process spawning. Assisted-by: Antigravity Signed-off-by: Samuel Karp <samuelkarp@google.com>
Add a new `enable_criu` configuration option under CRI plugin runtime settings. When set to false, any checkpoint or restore request will fail fast with an error indicating that CRIU support is disabled by configuration. `enable_criu` currently defaults to true. Add an integration test script to verify that setting `enable_criu` to false in containerd configuration successfully disables checkpoint and restore operations and fails fast. Assisted-by: Antigravity Signed-off-by: Samuel Karp <samuelkarp@google.com>
The Kubernetes E2E CI workflow was failing on tests requiring container checkpointing because criu was not installed on the GitHub Actions runner. Add a step to install criu via ppa:criu/ppa before building and installing containerd, matching the existing setup in ci.yml. Assisted-by: Antigravity Signed-off-by: Samuel Karp <samuelkarp@google.com>
Disable checkpoint restore codepath when CRIU is not installed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )