Implementing on-device ping#2510
Open
hank wants to merge 1 commit intomeshcore-dev:devfrom
Open
Conversation
The firmware UI had a feature to send an advert, which is useful, but often when out and about I'd like to ping a repeater and get a signal report, especially when scouting areas. I implemented this by making the last packet RSSI accessible, adding ping functionality to MyMesh and implementing some UI changes to allow selecting rows in the recent adverts screen with a long press, then short presses to move between rows, and a long press to send a ping. I also made the selection mode time out after 10 seconds.
Contributor
|
I'll test as soon as able, maybe not until next week sadly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The firmware UI had a feature to send an advert, which is useful, but often when out and about I'd like to ping a repeater and get a signal report, especially when scouting areas. I implemented this by making the last packet RSSI accessible, adding ping functionality to MyMesh and implementing some UI changes to allow selecting rows in the recent adverts screen with a long press, then short presses to move between rows, and a long press to send a ping. I also made the selection mode time out after 10 seconds.
The ping result shows signal in both directions: the rx line is what we hear from the repeater (from the response packet), and the tx line is what the repeater heard from us (parsed out of last_rssi/last_snr in the RepeaterStats response payload, matching what the Android companion app already displays). Extended showAlert to render multi-line popups so both lines fit, and bumped the success alert duration to 5 seconds so there's time to read both numbers.
Video Example of Use
I thought of this because my phone died while hiking and I wasn't able to ping the repeater anymore without it on my companion to see if I could hit it. Now I can!