chore: add publication for linux/arm64 for -cpu containers#665
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 68160b7e4d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
PyPI has only x86_64 wheels for onnxruntime-openvino and no source distributions, so arm64 builds failed unconditionally. Make the install a no-op on aarch64 and other non-x86_64 architectures. Tested locally: linux/arm64 CPU image builds and passes --help. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@wirthual can you review |
|
For reference:
The difference comes from the fact that Docker uses Linux torch libraries while local execution via So I ended up with using The difference might be worth documenting so others don't bump into it. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #665 +/- ##
==========================================
- Coverage 80.05% 80.00% -0.06%
==========================================
Files 43 43
Lines 3485 3485
==========================================
- Hits 2790 2788 -2
- Misses 695 697 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Hi, thanks for your contribution and sharing your findings. How do you benchmark the rerankers? Can you share the commands you use to run the servers? Also can you dump the installed packages in your environments? That would greatly help to look deeper into it. |
Can you please start releasing arm64 images as well?
Related Issue
Closes #616
Checklist