Add MM_HALOW_ENABLE_LWIP to control lwIP integration. - #3
Conversation
|
@kwagyeman a small change, see what you think. |
|
From Claude: Looks good — nice simplification, and defaulting One thing to confirm: is lwIP-off meant to be a buildable full-driver mode, or |
Signed-off-by: Damien George <damien@micropython.org>
No longer needed now that lwIP can be disabled in the driver. Signed-off-by: Damien George <damien@micropython.org>
4695c3b to
b7dd5db
Compare
Yes, eventually. Following cyw43-driver, I'd like to make a test that has a mock SPI backend and tests at least calling I've updated this PR so it can at least compile all src files with A follow-up PR can add a mock test that builds the whole thing. |
|
Okay, it's good. It's fine to merge. @dpgeorge |
kwagyeman
left a comment
There was a problem hiding this comment.
From claude:
Yes — approve it.
Why it's good to approve:
It does what it claims and CI is fully green (formatting, spelling, host×2, qemu×2).
My review point was addressed head-on. Damien consciously scoped this as incremental: all src files now compile with lwIP off, and he explicitly deferred the full standalone link (the mock-SPI test that "builds the whole thing") to a follow-up PR. That's a reasonable maintainer call, not an oversight.
|
Thanks! |
It's disabled by default. That allows the tests to be a lot simpler because they don't rely on lwIP anymore.