E-Document: process all records in OnAfterSend and OnAfterSendToEMail

[jeffreybulanadi]

Summary

When multiple posted documents are selected and sent using a Document Sending Profile configured for e-documents, only the first document was created as an e-document.

Root Cause

In EDocumentSubscribers.Codeunit.al, both OnAfterSendEDocument and OnAfterSendToEMailEDocument processed the incoming RecordVariant as a single record without iterating through all records in the set. The check and creation calls operated on the same fixed first record on every call.

Fix

Use RecordRef.GetTable + FindSet/Next to iterate over every record in the variant. In each iteration, the current RecordRef position is passed to IsEDocumentCreatedForRecord and CreateEDocumentFromPostedDocument so each document is independently checked and created.

For OnAfterSendToEMailEDocument, only the e-document creation loop is changed. The subsequent ProcessEDocumentAsEmail call continues to receive the original RecordVariant as it handles the email attachment step for the full selection.

Files Changed

• src/Apps/W1/EDocument/App/src/Processing/EDocumentSubscribers.Codeunit.al

Fixes #5650

Fixes AB#632028

[Groenbech96]

This change needs to have tests that cover the scenario.
Also the negative case that a single document, not multi selected, still creates a document.

[jeffreybulanadi]

Thank you for the feedback! Both test scenarios are already included in the second commit of this PR (2514b3a).

New test file: src/Apps/W1/EDocument/Test/src/Processing/EDocSendSubscriberTest.Codeunit.al (codeunit 139897 "E-Doc. Send Subscriber Test")

Test 1 - Multi-document scenario (the bug case):
SendMultiplePostedInvoicesCreatesEDocumentForEach

• Posts two invoices without auto E-Document creation (DSP disabled during post)
• Re-enables the extended E-Document service flow
• Calls DocumentSendingProfile.Send() with both invoices in the filtered RecordRef
• Asserts EDocument.Count() = 2 -- one E-Document per invoice

Test 2 - Single-document regression guard:
SendSinglePostedInvoiceCreatesOneEDocument

• Same setup pattern but with a single invoice
• Asserts EDocument.Count() = 1

Both tests follow the pattern from EDocEmailTests (bind EDocImplState, use LibraryEDoc.SetupStandardSalesScenario, disable DSP before posting, re-enable before sending). Local verification was also done on a BC 28 W1 Docker instance: Invoke-NAVCodeunit on the equivalent test codeunit completed with no failures in approximately 5 seconds.

[Copilot]

Pull request overview

Fixes E-Document creation when sending multiple posted documents via a Document Sending Profile by iterating over all records in the RecordVariant set, and adds regression tests to validate multi-record vs single-record sending.

Changes:

• Iterate through the full RecordVariant set in OnAfterSend and OnAfterSendToEMail subscribers to create an E-Document per selected posted document.
• Add integration tests that verify E-Documents are created for both multi-invoice and single-invoice send scenarios.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/Apps/W1/EDocument/App/src/Processing/EDocumentSubscribers.Codeunit.al	Updates event subscribers to loop over all records in the passed RecordVariant before checking/creating E-Documents.
src/Apps/W1/EDocument/Test/src/Processing/EDocSendSubscriberTest.Codeunit.al	Adds new integration tests covering multi-record and single-record send behavior for posted sales invoices.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[JesperSchulz]

Re-running CI.

[Groenbech96]

@copilot pull main into branch

[github-actions]

$\textbf{🟠\ High\ Severity\ —\ Performance} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

UnbindSubscription missing from try/finally

Both test procedures call UnbindSubscription(EDocImplState) at the end of the method body, but not inside a try/finally block. If any assertion or runtime error is thrown before reaching line 81 (or 131), the subscription remains bound for the remainder of the test session, potentially causing cascading failures in unrelated test codeunits.

Recommendation:

• Wrap the test body (after BindSubscription) in a try/finally block and call UnbindSubscription(EDocImplState) in the finally branch to guarantee cleanup regardless of test outcome.

Suggested change

	UnbindSubscription(EDocImplState);
	BindSubscription(EDocImplState);
	try
	// ... test body ...
	finally
	UnbindSubscription(EDocImplState);
	end;

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

$\textbf{🟠\ High\ Severity\ —\ Performance} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

UnbindSubscription missing from try/finally

Same subscription-leak risk as the first test: UnbindSubscription(EDocImplState) is called at the end of SendSinglePostedInvoiceCreatesOneEDocument but not inside a finally block, leaving the subscription active if the test errors out mid-run.

Recommendation:

• Wrap the test body in a try/finally block and place UnbindSubscription in the finally branch.

Suggested change

	UnbindSubscription(EDocImplState);
	BindSubscription(EDocImplState);
	try
	// ... test body ...
	finally
	UnbindSubscription(EDocImplState);
	end;

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Performance} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

DeleteAll on DocumentSendingProfile pollutes shared state

DocumentSendingProfile.DeleteAll() removes every document sending profile in the database. If another test codeunit in the same session runs after this and expects a default sending profile to already exist, it will fail with unexpected results. The cleanup at the start of each test covers the E-Document tables, but DocumentSendingProfile is shared system data.

Recommendation:

• Instead of DeleteAll(), isolate the test by creating a new profile with a distinct code, use it explicitly, and delete only that record in cleanup (or inside a finally block).

Suggested change

	DocumentSendingProfile.DeleteAll();
	// Create a dedicated test profile instead of DeleteAll
	DocumentSendingProfile.Init();
	DocumentSendingProfile.Code := 'TEST-EDOC';
	DocumentSendingProfile.Insert();

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Performance} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

DeleteAll on DocumentSendingProfile pollutes shared state

Same broad DocumentSendingProfile.DeleteAll() in SendSinglePostedInvoiceCreatesOneEDocument carries the same cross-test contamination risk described in the first test.

Recommendation:

• Scope the document sending profile to a test-specific code and clean up only that record.

Suggested change

	DocumentSendingProfile.DeleteAll();
	// Create a dedicated test profile instead of DeleteAll
	DocumentSendingProfile.Init();
	DocumentSendingProfile.Code := 'TEST-EDOC';
	DocumentSendingProfile.Insert();

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}