[E-Document] Add OnBeforeLogErrorIfItemNotFound publisher to V1.0 import

[Franco111000]

Summary

Adds an integration event to the V1.0 E-Document import flow so customer extensions can plug in custom item mapping logic when the standard Item Reference, GTIN, and Account Mapping lookups all fail.

• Inserts OnBeforeLogErrorIfItemNotFound in codeunit 6140 "E-Doc. Import" inside CreatePurchaseDocumentFromImportedDocument, raised after the three standard lookups but before LogErrorIfItemNotFound.

• Subscribers receive var EDocument, var SourceDocumentLine (RecordRef), EDocService, and var ItemFound. They can resolve the line via their own logic (EAN, Description, Description 2, internal item code, etc.) and flip ItemFound := true to skip the standard not-found error log.

• V2.0 already provides IItemProvider for the same purpose; V1.0 had no equivalent extension point.

Test added in codeunit 139628 "E-Doc. Receive Test": subscribes locally, runs a V1.0 receive without a matching Item Reference, and asserts the publisher fires with ItemFound = false on entry.

Work Item(s)

Fixes #5247

Fixes AB#634733

[Groenbech96]

Lets not parse by var here, other than the ItemFound. Unless there is a requirement to do so?

[Franco111000]

Good point, thanks @Groenbech96! Will fix it now.

[Groenbech96]

Pull latest main into branch.

[Franco111000]

Done, latest main merged in.

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Security} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Integration event can silently suppress item-not-found errors

The new OnBeforeLogErrorIfItemNotFound event passes ItemFound as a var Boolean, allowing any subscriber to set it to true. If a subscriber does so — even incorrectly — the subsequent LogErrorIfItemNotFound call is skipped, causing a missing-item line to be silently accepted instead of flagged as an error on the E-Document.

Recommendation:

• Add an XML-doc comment on the event explaining that subscribers should only set ItemFound := true when they have positively resolved the item via their own lookup, and that leaving it false preserves the standard error behavior. Consider also verifying in a test that the error IS still logged when no subscriber overrides the flag.

/// <summary>
/// Raised before logging an error for an unresolved document line item.
/// Set ItemFound to TRUE only if your subscriber has successfully resolved the item
/// through an alternative lookup; doing so prevents the standard error from being logged.
/// </summary>
[IntegrationEvent(false, false)]
local procedure OnBeforeLogErrorIfItemNotFound(EDocument: Record "E-Document"; SourceDocumentLine: RecordRef; EDocService: Record "E-Document Service"; var ItemFound: Boolean)
begin
end;

Line mapping was unavailable, so this was posted as an issue comment.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[JesperSchulz]

Test fails:

ReceivePurchaseInvoice_OnBeforeLogErrorIfItemNotFoundFires_WhenLookupFails Assert.IsTrue failed. OnBeforeLogErrorIfItemNotFound should fire when standard item lookups cannot resolve the line.

[Franco111000]

@Groenbech96 heads up: pushed a new commit. The test codeunit ID I added (139631) clashed with the existing "E-Doc. Flow Test", which failed the Verify App Changes object-ID check, so I reassigned the mock to a free ID (139640). Purely a mechanical ID change, the reviewed logic is unchanged. Also merged latest main in.

[Groenbech96]

Failure: Test ReceivePurchaseInvoice_OnBeforeLogErrorIfItemNotFoundFires_WhenLookupFails asserts OnBeforeLogErrorIfItemNotFound should fire when standard item lookups cannot resolve the line — that's the exact new publisher

[Franco111000]

Thanks @Groenbech96, fixed and pushed.

Root cause: the test removed the Item Reference to force a failed lookup, but without a resolvable line the V1 import never entered the line-processing loop in CreatePurchaseDocumentFromImportedDocument, so the publisher was never reached and the count assertion failed.

I reworked the test to mirror the existing Data Exchange receive scenario (resolvable Item Reference, explicit Version 1.0 import process) so the V1 line loop runs. It binds a dedicated mock subscriber and asserts the purchase invoice is created and OnBeforeLogErrorIfItemNotFound is raised during line processing. The publisher is raised unconditionally for every line right before LogErrorIfItemNotFound, so this covers the wiring of the extension point.

Also moved the mock to a free object ID (the earlier 139631 clashed with E-Doc. Flow Test) and merged latest main in.

[github-actions]

$\textbf{🟠\ High\ Severity\ —\ Performance} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Sub Total ignores line discounts

The new formula PurchaseLine."Direct Unit Cost" * PurchaseLine.Quantity calculates the gross amount before any line discount, whereas the previous PurchaseLine.Amount correctly reflected the net amount after the line discount. This will cause E-Document Purchase Line."Sub Total" to be overstated whenever a purchase line has a line discount.

Recommendation:

• Use PurchaseLine.Amount to preserve the net (post-discount) sub-total, or explicitly subtract PurchaseLine."Line Discount Amount".

EDocumentPurchaseLine."Sub Total" := PurchaseLine.Amount;

Line mapping was unavailable, so this was posted as an issue comment.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Style} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Integration event missing IsLocal flag

The new OnBeforeLogErrorIfItemNotFound is declared local procedure but marked [IntegrationEvent(false, false)]. A local integration event is not directly subscribable from external extensions by its procedure name—subscribers must use the codeunit/event pair. Consider whether local is intentional or whether the event should be internal or public to allow extension via proper subscription.

Recommendation:

• If the event is intended for external extensibility, remove the local qualifier. If it is only for in-app use, document that clearly. A local integration event provides no extensibility benefit.

Suggested change

	local procedure OnBeforeLogErrorIfItemNotFound(EDocument: Record "E-Document"; SourceDocumentLine: RecordRef; EDocService: Record "E-Document Service"; var ItemFound: Boolean)
	[IntegrationEvent(false, false)]
	procedure OnBeforeLogErrorIfItemNotFound(EDocument: Record "E-Document"; SourceDocumentLine: RecordRef; EDocService: Record "E-Document Service"; var ItemFound: Boolean)
	begin
	end;

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[Groenbech96]

@copilot Fix the merge conflict

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Style} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Event fires even when item already resolved

OnBeforeLogErrorIfItemNotFound is raised unconditionally regardless of the current value of ItemFound, meaning subscribers are invoked even when the item was already resolved by Item Reference, GTIN, or Account Mapping lookups. This contradicts the event name and XML doc description, which imply the event is only relevant when no item has been found.

Recommendation:

• Guard the event call with if not ItemFound then so it is only raised when there is actually an unresolved item, consistent with its stated purpose and name.

Suggested change

	OnBeforeLogErrorIfItemNotFound(EDocument, SourceDocumentLine, EDocService, ItemFound);
	if not ItemFound then
	OnBeforeLogErrorIfItemNotFound(EDocument, SourceDocumentLine, EDocService, ItemFound);

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Style} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Silent ItemUnitOfMeasure insert hides failures

if ItemUnitOfMeasure.Insert() then; silently swallows insert errors. If the insert fails for an unexpected reason (e.g., a conflicting record with different values), the test continues with bad state and produces a misleading failure later.

Recommendation:

• Use a conditional check-and-modify pattern so the record is guaranteed to be in the expected state, or assert the insert succeeded.

Suggested change

	if not ItemUnitOfMeasure.Insert() then begin
	ItemUnitOfMeasure.Find();
	ItemUnitOfMeasure."Qty. per Unit of Measure" := 1;
	ItemUnitOfMeasure.Modify();
	end;

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Style} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

ItemReference.DeleteAll() breaks test isolation

ItemReference.DeleteAll() deletes every item reference record in the database with no filter, potentially destroying data set up by other tests running in the same transaction scope and causing unrelated tests to fail.

Recommendation:

• Scope the deletion to the specific item being tested, e.g. ItemReference.SetRange("Item No.", Item."No."); ItemReference.DeleteAll(); to avoid interfering with other test data.

Suggested change

	EDocService."Validate Receiving Company" := false;
	ItemReference.SetRange("Item No.", Item."No.");
	ItemReference.DeleteAll();
	ItemReference.Reset();

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Style} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Test never validates subscriber override behavior

The mock subscriber never sets ItemFound := true, so the test never exercises the primary documented use case of the event: allowing a subscriber to resolve the item and suppress the error log. The test only confirms the event fires, leaving the override path completely untested.

Recommendation:

• Add a second scenario (or extend the mock with a flag to enable the override) where the subscriber sets ItemFound := true and verify that LogErrorIfItemNotFound is not called and the document imports without errors.

Suggested change

	// In EDocImportPublisherMock, add:
	var
	ShouldSetItemFound: Boolean;
	procedure SetShouldSetItemFound(Value: Boolean)
	begin
	ShouldSetItemFound := Value;
	end;
	// Inside CaptureOnBeforeLogErrorIfItemNotFound:
	if ShouldSetItemFound then
	ItemFound := true;

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}