[Quality Management] Feature uptake telemetry improvements

[JakovljevicDusan]

Fixes AB#637413

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Upgrade} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Feature 'Set up' telemetry event removed

The FeatureTelemetry.LogUptake('0000QIE', ..., "Set up") call was removed from the if not Rec.Get() branch. When basic setup is auto-created via EnsureBasicSetupExists, the 'Set up' uptake status is no longer recorded, creating a gap in the feature adoption funnel telemetry.

Recommendation:

• Restore the 'Set up' telemetry call in the branch where setup is newly auto-created, using Rec.GetFeatureTelemetryName() for consistency with the rest of the refactoring.

if not Rec.Get() then begin
    QltyAutoConfigure.EnsureBasicSetupExists(false);
    if Rec.Get() then
        FeatureTelemetry.LogUptake('0000QIE', Rec.GetFeatureTelemetryName(), Enum::"Feature Uptake Status"::"Set up");
end;

Line mapping was unavailable, so this was posted as an issue comment.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Performance} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Missing 'Set up' telemetry on auto-configuration path

The PR removes the FeatureTelemetry.LogUptake('0000QIE', ..., "Set up") call that previously fired when setup did not exist and was auto-created via EnsureBasicSetupExists. This tracking gap means customers who set up Quality Management through automatic configuration will not emit a Set up feature uptake event, underreporting actual adoption.

Recommendation:

• Re-add the Set up telemetry event after the auto-configuration succeeds (after the second Rec.Get()) using the new GetFeatureTelemetryName() helper.

        if not Rec.Get() then begin
            QltyAutoConfigure.EnsureBasicSetupExists(false);
            if Rec.Get() then
                FeatureTelemetry.LogUptake('0000QIE', Rec.GetFeatureTelemetryName(), Enum::"Feature Uptake Status"::"Set up");
        end;

Line mapping was unavailable, so this was posted as an issue comment.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[alexei-dobriansky]

discussing options on Teams with the author

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Style} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Inconsistent casing: LogFeatureUptakeSetUp vs SetUp

The call site uses LogFeatureUptakeSetUp (capital 'U' in 'Up') while the codeunit declares LogFeatureUptakeSetup (lowercase 'u'). AL identifiers are case-insensitive so this compiles, but the inconsistency will confuse readers and may cause issues if a future refactoring tool performs case-sensitive renames.

Recommendation:

• Align the call site with the declared procedure name: use LogFeatureUptakeSetup (all lowercase after 'Set').

QltyMgmtFeatureTelemetry.LogFeatureUptakeSetup(ObjectType::Page, Page::"Qlty. Management Setup");

Line mapping was unavailable, so this was posted as an issue comment.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

$\textbf{🔴\ Critical\ Severity\ —\ Performance} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

OnInsertRecord implicitly returns false

The new OnInsertRecord trigger has return type Boolean but never calls exit(true). In AL, an unset Boolean return value defaults to false, and returning false from OnInsertRecord cancels the insert — meaning no new Inspection Template records can ever be saved.

Recommendation:

• Add exit(true); at the end of the trigger body so the insert is not suppressed when telemetry logging is the only action taken.

    trigger OnInsertRecord(BelowxRec: Boolean): Boolean
    var
        QltyMgmtFeatureTelemetry: Codeunit "Qlty. Mgmt. Feature Telemetry";
    begin
        QltyMgmtFeatureTelemetry.LogFeatureUptakeSetup(ObjectType::Page, Page::"Qlty. Inspection Template");
        exit(true);
    end;

Line mapping was unavailable, so this was posted as an issue comment.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}