28.0: Render per-row Currency Code in Aged Accounts Receivable/Payable Excel#8427
Open
mynjj wants to merge 5 commits into
Open
28.0: Render per-row Currency Code in Aged Accounts Receivable/Payable Excel#8427mynjj wants to merge 5 commits into
mynjj wants to merge 5 commits into
Conversation
The CurrencyCode column was bound to a single AgingData-buffer-wide variable (CurrencyCodeDisplayCode) computed once after InsertAgingData, so every row of a customer/vendor displayed the same currency — the last one inserted. When a customer/vendor had entries in multiple currencies, foreign-currency rows showed the LCY code (or vice versa). Bind the column to AgingData."Currency Code" directly, and fall back to G/L Setup's LCY Code at insertion time when the ledger entry's Currency Code is empty. Fixes AB#637444
The cherry-pick from main brought over tests for unrelated scenarios (Document Type/No export, Aging by Posting Date) that were moved from TrialBalanceExcelReports on main. Those scenarios were never present on 28.0, so they don't belong in this backport. Drop them and the helpers they exclusively used; keep only the two SCENARIO 637444 tests.
CurrencyCodeDisplayCode is a protected variable and cannot be removed, so assign AgingData."Currency Code" to it after InsertAgingData. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
djukicmilica
previously approved these changes
Jun 3, 2026
| CurrencyCodeDisplayCode := GeneralLedgerSetup.GetCurrencyCode('') | ||
| else | ||
| CurrencyCodeDisplayCode := AgingData."Currency Code"; | ||
| CurrencyCodeDisplayCode := AgingData."Currency Code"; |
Contributor
There was a problem hiding this comment.
CurrencyCodeDisplayCode is not used anymore
| CurrencyCodeDisplayCode := GeneralLedgerSetup.GetCurrencyCode('') | ||
| else | ||
| CurrencyCodeDisplayCode := AgingData."Currency Code"; | ||
| CurrencyCodeDisplayCode := AgingData."Currency Code"; |
Contributor
There was a problem hiding this comment.
CurrencyCodeDisplayCode is not used anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8423. Fixes AB#637446. Cherry-pick conflict in TrialBalanceExcelReports.Codeunit.al resolved by keeping 28.0's existing tests untouched — the deleted/moved tests (AgedAccountsPayableExportsDocumentTypeAndNo / AgedAccountsRecExportsDocumentTypeAndNo) did not exist on 28.0, so only the new AgedAccountsExcelReports codeunit is added.