Skip to content

[Quality Management] Add multi-select test action in templates#8432

Open
JakovljevicDusan wants to merge 10 commits into
mainfrom
bugs/QM-AddMultipleTests
Open

[Quality Management] Add multi-select test action in templates#8432
JakovljevicDusan wants to merge 10 commits into
mainfrom
bugs/QM-AddMultipleTests

Conversation

@JakovljevicDusan
Copy link
Copy Markdown
Contributor

@JakovljevicDusan JakovljevicDusan commented Jun 2, 2026

What & why

image

Linked work

Fixes AB#618886

@JakovljevicDusan JakovljevicDusan requested a review from a team as a code owner June 2, 2026 21:47
@github-actions github-actions Bot added the AL: Apps (W1) Add-on apps for W1 label Jun 2, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Jun 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

$\textbf{🟡\ Medium\ Severity\ —\ Style} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Second overload obsolete message also misleads callers

The two-parameter overload of AddTestToTemplate carries the same obsolete message pointing to the local procedure AddTestToTemplateLine, making it equally misleading for consumers of this public API who need to understand what they should migrate to.

Recommendation:

  • Apply the same fix as for the single-parameter overload — reference the accessible AddSelectedTests or SelectMultipleTests procedures in the obsolete message.
[Obsolete('Replaced by SelectMultipleTests() / AddSelectedTests() on "Qlty. Inspection Template Line".', '29.0')]

Line mapping was unavailable, so this was posted as an issue comment.

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why

@JakovljevicDusan JakovljevicDusan enabled auto-merge (squash) June 4, 2026 08:53
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

$\textbf{🟡\ Medium\ Severity\ —\ Style} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Tooltip references non-existent 'Field template'

The updated Allowable Values ToolTip says "the Allowable Values field on the Field template" but there is no concept called 'Field template' in this application; the value is sourced from the test template (Qlty. Test). This is a factual error introduced by the edit.

Recommendation:

  • Replace 'Field template' with 'Test template' (or 'Qlty. Test') to match the actual source of the value.
ToolTip = 'Specifies an expression for the range of values you can enter or select on the Quality Inspection line. The program automatically retrieves the value from the Allowable Values field on the Test template.';

Line mapping was unavailable, so this was posted as an issue comment.

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why

internal procedure GetSelectionFilter(): Text
var
QltyTest: Record "Qlty. Test";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: empty line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants