Skip to content

Add MultiInsertStrategy implementations for BfTreeProvider#949

Open
hildebrandmw wants to merge 1 commit intomainfrom
mhildebr/bf-tree-multi-insert
Open

Add MultiInsertStrategy implementations for BfTreeProvider#949
hildebrandmw wants to merge 1 commit intomainfrom
mhildebr/bf-tree-multi-insert

Conversation

@hildebrandmw
Copy link
Copy Markdown
Contributor

These implementations were missed in #859 which broke some internal test code. No tests are added since the internal code that broke was largely serving as the tests, and we don't seem to have any current tests for BfTreeProvider anyways.

@hildebrandmw hildebrandmw requested review from a team and Copilot April 15, 2026 00:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds missing MultiInsertStrategy implementations for BfTreeProvider to restore internal test/usage paths that broke after #859.

Changes:

  • Introduce a pq::Overlay type alias for HybridMap working-set overlays.
  • Implement MultiInsertStrategy for BfTreeProvider in both FullPrecision and Hybrid modes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
diskann-providers/src/model/graph/provider/async_/distances.rs Adds an overlay type alias used as the seed for multi-insert flows with PQ/hybrid distances.
diskann-providers/src/model/graph/provider/async_/bf_tree/provider.rs Adds MultiInsertStrategy impls so batch insert paths can build the appropriate working set/overlay for BfTreeProvider.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread diskann-providers/src/model/graph/provider/async_/distances.rs
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.31%. Comparing base (779977c) to head (fdb3cca).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #949      +/-   ##
==========================================
- Coverage   89.32%   89.31%   -0.01%     
==========================================
  Files         447      447              
  Lines       83891    83891              
==========================================
- Hits        74934    74931       -3     
- Misses       8957     8960       +3     
Flag Coverage Δ
miri 89.31% <ø> (-0.01%) ⬇️
unittests 89.16% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...iders/src/model/graph/provider/async_/distances.rs 47.88% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

std::future::ready(Ok(overlay))
}
}

Copy link
Copy Markdown
Contributor

@harsha-simhadri harsha-simhadri Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there tests already to cover this code path? if not, please add.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I called this out in the PR description: there are no meaningful tests for BfTreeProvider. The only tests were code in our internal Python package (which I broke with the multi-insert change and this is fixing 😢). Writing tests here would involve standing up the entire test ecosystem for the BfTreeProvider, which I really don't think is a good use of time at the moment. In any case, this particular change is 95% checked by the compiler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants