Add ServiceNow ITSM connect support for ESS IT - #353
Draft
DapheneShao wants to merge 2 commits into
Draft
DapheneShao wants to merge 2 commits into
DapheneShao wants to merge 2 commits into
Conversation
Generalize the DA ServiceNow workflow across HRSD and ITSM, add invocation-scoped ESS agent selection, and preserve the verified maker-assisted connection boundary. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
DapheneShao
added this pull request to stack #354
September 26, 2026 07:10
Keep MinimalBot enumeration as the primary source, then directly verify authoring-ready configured Dev agents that the list endpoint omitted. Report exact lookup failures without fabricating selectable agents. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
DapheneShao please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ITSM follow-up stacked on #331. This keeps #331 as the Employee Self-Service (HR) + ServiceNow HRSD baseline and generalizes the same DA ServiceNow workflow through small HRSD/ITSM product profiles.
/connect servicenowinvocation.local/config.json.activeAgentValidation
python -m pytest tests/scripts/test_agentbuilder.py tests/scripts/test_setup_existing_da.py tests/setup/test_da_setup_router.py -k 'servicenow or connect' tests/scripts/test_connect_servicenow_da.py tests/setup/test_servicenow_da_connect_router.py -q— 42 passedpython -m ruff check solutions/ess-maker-skills/scripts/connect_servicenow_da.py tests/scripts/test_connect_servicenow_da.py tests/setup/test_servicenow_da_connect_router.py— passedpython solutions/ess-maker-skills/scripts/connect_servicenow_da.py --help— passedgit diff --check— passedA broader related test run completed 192 tests and found two unrelated existing prompt-text assertion failures in
tests/setup/test_da_setup_router.py; neither touches the ServiceNow connect path.Agent-discovery fallback fix at head
d4de6a35fecd3ca0c158b8ce742725c2fd595892:list=[] + canonical IT ready + exact 200, unchangedactiveAgent, exact identity mismatch, and exact authorization failurelist-agentsvalidation — passed; returned Employee Self-Service (IT) asServiceNow ITSM,status: ready,selectable: true, with no discovery errorsRemaining live validation
The Agent-discovery blocker is fixed and live-validated. The user can now continue with
/connect servicenow.Before this PR is ready, a maker must complete the remaining validation gates against the real Employee Self-Service (IT) agent and ServiceNow ITSM connection:
inspectand review the selected ITSM topicsentraIDUserLogincredential if neededPhysical credential creation/sign-in, Agent Connect, conditional parameter sharing, and Test pane validation remain maker-assisted because #331 established no approved API for those actions. This PR remains Draft until the remaining gates pass.