feat: move selected nodes between Spaces - #148
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Yuqing (mydmdm)
changed the title
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Support named new Space destinations and leave a footprint-sized Space Preview breadcrumb at the source location. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add a default-enabled Move option for leaving the destination Space preview at the source location. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Validate both rename operands as direct Workspace children at the filesystem boundary. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ed in path expression' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
… data used in path expression'" This reverts commit ba8ee60.
Resolve direct Workspace children through a shared containment helper recognized by the path-injection query. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Direct agents to the shared CodeQL-aware path confinement helpers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Yuge Zhang (ultmaster)
added a commit
to ultmaster/Huabu
that referenced
this pull request
Sep 3, 2026
Two conflicts, one textual and one semantic. `docs/architecture/canvas-storage.md`: main added the `resolveDirectChildPath()` rename boundary above the paragraph this branch rewrote. Both kept — the new paragraph, then this branch's version of the deletion paragraph, whose last sentence stops calling the residual direct-filesystem capabilities blockers for a non-Disk profile now that the matrix declares them. Cross-Space Move (microsoft#148) was written against the previous blob port and did not conflict textually: it reached `getBlobStore().scope({kind: 'canvas', canvasId})`, which this branch replaced with one area per user-visible family behind `space(canvasId)`. Its artifact clone now reads and writes through `space(id).artifacts`, which also puts the destination write behind the cross-store rule the facade owns — a Space deleted mid-move can no longer take orphan bytes with it. Verified on the merge: server 1187 passed, web 1149 passed, shared 379 passed, typecheck across every package, lint (0 errors), format, i18n parity, and license headers. The `Agenetes.rehome` type errors seen first were a stale subtree build, not a merge defect — `pnpm run build:agenetes` clears them. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011J3JGQNx3Aecxc96HeuTPc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pnpm typecheckpnpm formatpnpm lint:fixCloses #142